Add information about class in error message of schema generation #8917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sydney-runkle
suggested changes
Feb 29, 2024
pydantic-hooky
bot
added
the
awaiting author revision
CodSpeed Performance ReportMerging #8917 will not alter performanceComparing Summary
|
sydney-runkle
suggested changes
Feb 29, 2024
Co-authored-by: Sydney Runkle <54324534+sydney-runkle@users.noreply.github.com>
|
You should be able to run |
|
I think that I have done it. |
|
Looks like you fixed the linting, but your test is failing |
I see, but your workflow is totally different from this one that I’m familiar with, and it takes me longer time to identify how to test things locally. |
sydney-runkle
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Finally, the last of my dependency reached pydantic 2 compatibility, so I could start migrating my package. I meet an error that requires using a debugger to understand where is a problem as I cannot find which class is responsible for the problem. In this PR I add information about class that have
__modify_schema__and do not have__get_pydantic_json_schema__Related issue number
Checklist