KEMBAR78
allow field_serializer('*') (fix #8990) by ornariece · Pull Request #9001 · pydantic/pydantic · GitHub
Skip to content

allow field_serializer('*') (fix #8990) #9001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 14, 2024
Merged

allow field_serializer('*') (fix #8990) #9001

merged 6 commits into from
Mar 14, 2024

Conversation

@ornariece
Copy link
Contributor

@ornariece ornariece commented Mar 13, 2024 •
edited by pydantic-hooky bot
Loading

Change Summary

allow field_serializer('*') for defining a serializer for all fields in a model

Related issue number

fix #8990

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @davidhewitt

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 13, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9001 will not alter performance

Comparing ornariece:field_serializer_all (707fd47) with main (18d39fe)

Summary

✅ 10 untouched benchmarks

@ornariece
Copy link
Contributor Author

please review @sydney-runkle

sydney-runkle
sydney-runkle suggested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bit of feedback. Thanks for your work on this :). And thanks for the tests!

@pydantic-hooky pydantic-hooky bot added awaiting author revision awaiting changes from the PR author and removed ready for review labels Mar 13, 2024
@pydantic-hooky pydantic-hooky bot assigned ornariece and unassigned davidhewitt Mar 13, 2024
@ornariece @sydney-runkle
Update docs/concepts/serialization.md
fa14490 
Co-authored-by: Sydney Runkle <54324534+sydney-runkle@users.noreply.github.com>
sydney-runkle
sydney-runkle approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ornariece,

Looks great, but please fix the linting errors before we merge!

@ornariece
Copy link
Contributor Author

turns out the initial doc change was correct 😄

@sydney-runkle
Copy link
Contributor

@ornariece,

Hmm, I don't think it was -- I think you just needed to fix the whitespace... could you try that instead?

@ornariece
Copy link
Contributor Author

here's to hoping i checked everything properly this time! sorry for the trouble

@sydney-runkle
Copy link
Contributor

No worries at all. Looks great, thanks so much :).

@sydney-runkle sydney-runkle enabled auto-merge (squash) March 14, 2024 00:04
@sydney-runkle sydney-runkle merged commit 534a446 into pydantic:main Mar 14, 2024
@ornariece ornariece deleted the field_serializer_all branch March 14, 2024 14:33
@bonauer-pf bonauer-pf mentioned this pull request Jun 18, 2024
Closed
1 task
@micahwoodard micahwoodard mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ornariece ornariece

Labels

awaiting author revision awaiting changes from the PR author relnotes-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

field_serializer('*')

3 participants

@ornariece @sydney-runkle @davidhewitt