Fix handling of optionals in mypy plugin #9008
Conversation
Deploying pydantic-docs with
|
| Latest commit: |
2ce76e8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1ec456aa.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://dmontagu-fix-mypy-optional-s.pydantic-docs2.pages.dev |
dmontagu
force-pushed
the
dmontagu/fix-mypy-optional-stuff
branch
from
748d46d to
ded66e1
Compare
CodSpeed Performance ReportMerging #9008 will not alter performanceComparing Summary
|
|
Is there a test case we should add here? Also, I wonder, should we be setting a minimum supported version of mypy for the plugin? I don't know if it's practical for us to throw an exception if the mypy version is too old? |
I think it would make sense to drop some older versions of mypy, especially because before around 1.1 support for |
|
1.1.1 is a year old, so that might be a suitable cutoff point. Or we could try to go further, 1.5.1 is 6 months old. It would be nice with either limit if we could fail gracefully if users try an older mypy. |
|
I have added a test, but I'll note that the only affected version that we test against is mypy 1.5.1 (and we install 1.1.1 by default in pydantic). We should probably update the versions we test against soon. I'm not prepared to do that in this PR though. |
pydantic-hooky
bot
added
the
awaiting author revision
|
Great, thank you very much @dmontagu !! |
The Pydantic version we used before has an issue in the mypy plugin which can lead to actual typing errors slipping through, see pydantic/pydantic#9008. Note that the version we udpate to has this issue: pydantic/pydantic#9319 However, since a workaround is available, we still udpate to avoid introducing new typing errors. Also fix newly found issues. Apparently, polyfactory now has issues with handling field aliases, so we switch to validation aliases, which are sufficient in this case. CMK-17006 Change-Id: I8b8ebb072f0c68b799d28c132c5f5605232db9c7
4 participants
I think this may resolve various occurrences of mypy issues with optional, such as #9007
Mirrors the changes to the dataclasses plugin in python/mypy#15571
Fix #9007
Fix #8760