KEMBAR78
really drop python<=3.7 support by kloczek · Pull Request #9047 · pydantic/pydantic · GitHub
Skip to content

Conversation

@kloczek
Copy link
Contributor

@kloczek kloczek commented Mar 19, 2024

Change Summary

Filter all code over pyupgrade --py38.

Related issue number

N/A

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 19, 2024

CodSpeed Performance Report

Merging #9047 will not alter performance

Comparing kloczek:main (468a897) with main (99147ca)

Summary

✅ 10 untouched benchmarks

@Viicos
Copy link
Member

Viicos commented Mar 19, 2024

I believe the v1 code should be left as is

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, @Viicos is right! Let's leave the V1 code as is. Happy to review again once that's changed - thanks!

@pydantic-hooky pydantic-hooky bot added the awaiting author revision awaiting changes from the PR author label Mar 21, 2024
@kloczek
Copy link
Contributor Author

kloczek commented Mar 21, 2024

Indeed, @Viicos is right! Let's leave the V1 code as is. Happy to review again once that's changed - thanks!

OK .. however I'm not sure about you are talking about so please close this PR and to it by yourself or merge than correct what still should be rolled back 😋
If it anything wrong what have been filtered incorrectly by pyupgrade please report that on https://github.com/asottile/pyupgrade

@Viicos
Copy link
Member

Viicos commented Mar 21, 2024

Basically the v1 folder is a port of Pydantic V1 so that even in Pydantic V2, the v1 code can be imported under pydantic.v1. But this code should be identical to what is available on the 1.x branch.

Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove the unused typing.Dict and typing.Optional imports? That should fix the pipeline for good!

@kloczek
Copy link
Contributor Author

kloczek commented Mar 21, 2024

Could you please remove the unused typing.Dict and typing.Optional imports? That should fix the pipeline for good!

In updated PR are only changes in tests/ and I see in that new diff any fiddling around imports 🤔

@sydney-runkle
Copy link
Contributor

In updated PR are only changes in tests/ and I see in that new diff any fiddling around imports 🤔

All good, I made the fixes. Thanks!

@sydney-runkle sydney-runkle added the relnotes-ignore Omit this PR from the release notes. label Mar 21, 2024
@kloczek
Copy link
Contributor Author

kloczek commented Mar 21, 2024

OK now I see about what it was 😋
How did you font that? Using ruff? 🤔

@sydney-runkle sydney-runkle enabled auto-merge (squash) March 21, 2024 18:54
@sydney-runkle
Copy link
Contributor

@kloczek,

Yep, you can use ruff. The issue was also reported in our lint jobs

@sydney-runkle sydney-runkle merged commit 04cc047 into pydantic:main Mar 21, 2024
@kloczek
Copy link
Contributor Author

kloczek commented Mar 21, 2024

Thank you because I had again opportunity to learned few small new details 👍 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting author revision awaiting changes from the PR author relnotes-ignore Omit this PR from the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants