KEMBAR78
clickhouse-dsn by solidguy7 · Pull Request #9062 · pydantic/pydantic · GitHub
Skip to content

Conversation

@solidguy7
Copy link
Contributor

@solidguy7 solidguy7 commented Mar 20, 2024

ClickhouseDsn

Just added dsn for Clickhouse

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 20, 2024

CodSpeed Performance Report

Merging #9062 will not alter performance

Comparing solidguy7:clickhouse-dsn (be315e8) with main (a3b7214)

Summary

✅ 10 untouched benchmarks

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks!

'NatsDsn',
'MySQLDsn',
'MariaDBDsn',
'ClickhouseDsn',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be ClickHouseDsn...

@pydantic-hooky pydantic-hooky bot added the awaiting author revision awaiting changes from the PR author label Mar 21, 2024
@solidguy7 solidguy7 requested a review from sydney-runkle March 21, 2024 16:15
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!!

@sydney-runkle sydney-runkle enabled auto-merge (squash) March 21, 2024 16:20
@sydney-runkle sydney-runkle merged commit 99147ca into pydantic:main Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting author revision awaiting changes from the PR author relnotes-feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants