KEMBAR78
Fix discriminated union bug with unsubstituted type var by sydney-runkle · Pull Request #9124 · pydantic/pydantic · GitHub
Skip to content

Conversation

@sydney-runkle
Copy link
Contributor

@sydney-runkle sydney-runkle commented Mar 27, 2024

Fix #9118, see test for details :).

Selected Reviewer: @davidhewitt

@sydney-runkle
Copy link
Contributor Author

Please review

@cloudflare-workers-and-pages
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8c33f06
Status: ✅  Deploy successful!
Preview URL: https://88755251.pydantic-docs2.pages.dev
Branch Preview URL: https://discriminator-fixes-again.pydantic-docs2.pages.dev

View logs

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 27, 2024

CodSpeed Performance Report

Merging #9124 will not alter performance

Comparing discriminator_fixes_again (8c33f06) with main (548feec)

Summary

✅ 13 untouched benchmarks

@sydney-runkle sydney-runkle enabled auto-merge (squash) March 27, 2024 17:29
@sydney-runkle sydney-runkle merged commit 7ac7881 into main Mar 27, 2024
@sydney-runkle sydney-runkle deleted the discriminator_fixes_again branch March 27, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discriminated union type breaks from 2.6.3 to 2.6.4: TypeError: 'none' is not a valid discriminated union variant; should be a BaseModel or dataclass

3 participants