Remove update_json_schema (bad practice func)
#9125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
39075f3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2f462969.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://remove-old-json-schema-func.pydantic-docs2.pages.dev |
|
Please review |
sydney-runkle
added
the
relnotes-change
CodSpeed Performance ReportMerging #9125 will not alter performanceComparing Summary
|
alexmojaki
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
I think this is OK to merge, but I will point out that @dmontagu and the issue title said to deprecate the function, not remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8381
Removing a function that was minimally used, and was following bad practice. This function was problematic in that it both:
This is technically a change (bc the
update_json_schemafunc was public), but I'm not too concerned about this - it was a think wrapper around thesome_dict.updatefunction, so it can easily be replaced. I've marked this asrelnotes-changeaccordingly, and will draw attention to this in the release notes.Selected Reviewer: @alexmojaki