KEMBAR78
Support serialization of `deque` when passed to `Sequence[blah blah blah]` by sydney-runkle · Pull Request #9128 · pydantic/pydantic · GitHub
Skip to content

Conversation

@sydney-runkle
Copy link
Contributor

@sydney-runkle sydney-runkle commented Mar 27, 2024

Fix #7797

Selected Reviewer: @samuelcolvin

@sydney-runkle sydney-runkle added the relnotes-fix Used for bugfixes. label Mar 27, 2024
@sydney-runkle
Copy link
Contributor Author

Please review

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 27, 2024

CodSpeed Performance Report

Merging #9128 will not alter performance

Comparing deque_serialization (c7035cd) with main (b30f44d)

Summary

✅ 13 untouched benchmarks

@sydney-runkle sydney-runkle enabled auto-merge (squash) March 27, 2024 21:16
@sydney-runkle sydney-runkle merged commit 477e0a2 into main Mar 27, 2024
@sydney-runkle sydney-runkle deleted the deque_serialization branch March 27, 2024 21:21
jvansanten added a commit to AmpelProject/Ampel-interface that referenced this pull request May 28, 2024
False-positive warnings appear to have been fixed in
pydantic/pydantic#9111 and possibly
pydantic/pydantic#9128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add deque to serialization when Sequence is used as type hinting in V2

3 participants