KEMBAR78
Rust enums validator by samuelcolvin · Pull Request #1235 · pydantic/pydantic-core · GitHub
Skip to content

Rust enums validator #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 20, 2024
Merged

Rust enums validator #1235

merged 17 commits into from
Mar 20, 2024

Conversation

@samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Mar 19, 2024 •
edited
Loading

Change Summary

Enum validation in rust, gives a nice >4x speedup.

image

Still to do:

  • floats
  • serialization

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 19, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1235 will not alter performance

Comparing enum-validator (770e436) with main (abff9ba)

Summary

✅ 148 untouched benchmarks

🆕 4 new benchmarks

Benchmarks breakdown

Benchmark main enum-validator Change
🆕 test_enum_int_core N/A 20.4 µs N/A
🆕 test_enum_int_python N/A 39 µs N/A
🆕 test_enum_str_core N/A 21 µs N/A
🆕 test_enum_str_python N/A 38.7 µs N/A

@samuelcolvin samuelcolvin changed the title custom enums validator Rust enums validator Mar 19, 2024
samuelcolvin
samuelcolvin commented Mar 20, 2024
View reviewed changes
samuelcolvin
samuelcolvin commented Mar 20, 2024
View reviewed changes
samuelcolvin
samuelcolvin commented Mar 20, 2024
View reviewed changes
samuelcolvin
samuelcolvin commented Mar 20, 2024
View reviewed changes
davidhewitt
davidhewitt approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, no changes needed just passing thoughts!

davidhewitt
davidhewitt reviewed Mar 20, 2024
View reviewed changes
@samuelcolvin samuelcolvin merged commit d73668f into main Mar 20, 2024
@samuelcolvin samuelcolvin deleted the enum-validator branch March 20, 2024 15:08
@samuelcolvin samuelcolvin mentioned this pull request Mar 20, 2024
Merged
5 tasks
@ngnpope ngnpope mentioned this pull request Apr 5, 2024
Closed
@Idealcoder Idealcoder mentioned this pull request May 2, 2024
Closed
1 task
davidhewitt pushed a commit to pydantic/pydantic that referenced this pull request Oct 20, 2025
@samuelcolvin
Rust enums validator (pydantic/pydantic-core#1235)
ac178fa 
Original-commit-hash: d73668f
davidhewitt pushed a commit to pydantic/pydantic that referenced this pull request Oct 22, 2025
@samuelcolvin
Rust enums validator (pydantic/pydantic-core#1235)
bbce76f 
Original-commit-link: pydantic/pydantic-core@d73668f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees

@davidhewitt davidhewitt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samuelcolvin @davidhewitt