gh-104835: Remove unittest's deprecated getTestCaseNames, makeSuite, findTestCases #104836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted in Python 3.11
JelleZijlstra
approved these changes
May 24, 2023
markmentovai
added a commit
to markmentovai/pyftdi
that referenced
this pull request
Nov 4, 2024
```
ImportError while importing test module '…/pyftdi/pyftdi/tests/toolsimport.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
…/lib/python3.13/importlib/__init__.py:88: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
pyftdi/tests/toolsimport.py:16: in <module>
from unittest import TestCase, TestSuite, makeSuite, main as ut_main
E ImportError: cannot import name 'makeSuite' from 'unittest' (…/lib/python3.13/unittest/__init__.py)
```
python/cpython#104835
python/cpython#104836
python/cpython@b1cb30e
https://docs.python.org/3/whatsnew/3.13.html#unittest
eblot
pushed a commit
to eblot/pyftdi
that referenced
this pull request
Nov 19, 2024
```
ImportError while importing test module '…/pyftdi/pyftdi/tests/toolsimport.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
…/lib/python3.13/importlib/__init__.py:88: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
pyftdi/tests/toolsimport.py:16: in <module>
from unittest import TestCase, TestSuite, makeSuite, main as ut_main
E ImportError: cannot import name 'makeSuite' from 'unittest' (…/lib/python3.13/unittest/__init__.py)
```
python/cpython#104835
python/cpython#104836
python/cpython@b1cb30e
https://docs.python.org/3/whatsnew/3.13.html#unittest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #104835.
Remove
unittest'sfindTestCases,makeSuiteandgetTestCaseNames, deprecated in Python 3.11 in gh-50096 and scheduled for removal in 3.13.Use
unittest.TestLoadermethods instead:unittest.TestLoader.loadTestsFromModuleunittest.TestLoader.loadTestsFromTestCaseunittest.TestLoader.getTestCaseNames📚 Documentation preview 📚: https://cpython-previews--104836.org.readthedocs.build/