KEMBAR78
gh-105052:update timeit function's description by Cherrymelon · Pull Request #105060 · python/cpython · GitHub
Skip to content

gh-105052:update timeit function's description #105060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 27, 2023
Merged

gh-105052:update timeit function's description #105060

merged 9 commits into from
Aug 27, 2023

Conversation

@Cherrymelon
Copy link
Contributor

@Cherrymelon Cherrymelon commented May 29, 2023 •
edited
Loading

Update time unit description in timeit function and add note to timeit doc page

@bedevere-bot bedevere-bot mentioned this pull request May 29, 2023
Closed
@ghost
Copy link

ghost commented May 29, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

terryjreedy
terryjreedy requested changes May 29, 2023
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR could have waited for more discussion on the issue. See this comment for what I think the most important change for this issue should be, and where.

The Timer docstring has an obsolete and now wrong statement about the timer that should be deleted: ; the timer function is platform-dependent (see the module doc string)

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@python python deleted a comment from bedevere-bot Aug 27, 2023
terryjreedy
terryjreedy reviewed Aug 27, 2023
View reviewed changes
@terryjreedy terryjreedy added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Aug 27, 2023
terryjreedy
terryjreedy reviewed Aug 27, 2023
View reviewed changes
@terryjreedy terryjreedy merged commit 7096a2b into python:main Aug 27, 2023
@miss-islington
Copy link
Contributor

Thanks @Cherrymelon for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-108534 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 27, 2023
@Cherrymelon @miss-islington
pythongh-105052:update timeit function's description (pythonGH-105060)
dea171c 
---------
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 7096a2b)

Co-authored-by: R <cherrymelon@foxmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 27, 2023
@bedevere-bot
Copy link

GH-108535 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 27, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 27, 2023
@Cherrymelon @miss-islington
pythongh-105052:update timeit function's description (pythonGH-105060)
bf40fb8 
---------
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 7096a2b)

Co-authored-by: R <cherrymelon@foxmail.com>
terryjreedy pushed a commit that referenced this pull request Aug 27, 2023
@miss-islington @Cherrymelon
[3.11] gh-105052:update timeit function's description (GH-105060) (#1…
8a275f7 
…08535)

---------
Co-authored-by: Terry Jan Reedy tjreedy@udel.edu
Co-authored-by: R <cherrymelon@foxmail.com>
(cherry picked from commit 7096a2b)
Yhg1s pushed a commit that referenced this pull request Aug 27, 2023
@miss-islington @Cherrymelon
[3.12] gh-105052:update timeit function's description (GH-105060) (#1…
0b0238d 
…08534)

gh-105052:update timeit function's description (GH-105060)

---------

(cherry picked from commit 7096a2b)

Co-authored-by: R <cherrymelon@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Cherrymelon @bedevere-bot @miss-islington @terryjreedy @hugovk