KEMBAR78
gh-105549: Tokenize separately NUMBER and NAME tokens and allow 0-prefixed literals by pablogsal · Pull Request #105555 · python/cpython · GitHub
Skip to content

gh-105549: Tokenize separately NUMBER and NAME tokens and allow 0-prefixed literals #105555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2023
Merged

gh-105549: Tokenize separately NUMBER and NAME tokens and allow 0-prefixed literals #105555

merged 2 commits into from
Jun 9, 2023

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal requested a review from lysnikolaou as a code owner June 9, 2023 12:11
@pablogsal pablogsal added the needs backport to 3.12 only security fixes label Jun 9, 2023
@pablogsal pablogsal changed the title Tokenize separately NUMBER and NAME tokens and allow 0-prefixed literals gh-105549: Tokenize separately NUMBER and NAME tokens and allow 0-prefixed literals Jun 9, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 9, 2023
Closed
@pablogsal pablogsal mentioned this pull request Jun 9, 2023
Closed
sylee957
sylee957 reviewed Jun 9, 2023
View reviewed changes
@pablogsal pablogsal force-pushed the gh-105549 branch 2 times, most recently from f87ab0d to 58ccc64 Compare June 9, 2023 16:03
terryjreedy
terryjreedy reviewed Jun 9, 2023
View reviewed changes
@pablogsal
Allow 0-prefixed underscore literals
558552a 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@pablogsal pablogsal merged commit b047fa5 into python:main Jun 9, 2023
@pablogsal pablogsal deleted the gh-105549 branch June 9, 2023 20:39
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 9, 2023
@pablogsal @miss-islington
pythongh-105549: Tokenize separately NUMBER and NAME tokens and allow…
126aefe 
… 0-prefixed literals (pythonGH-105555)

(cherry picked from commit b047fa5)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot
Copy link

GH-105602 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 9, 2023
pablogsal added a commit that referenced this pull request Jun 9, 2023
@miss-islington @pablogsal
[3.12] gh-105549: Tokenize separately NUMBER and NAME tokens and allo…
ae6e002 
…w 0-prefixed literals (GH-105555) (#105602)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy left review comments

@AlexWaygood AlexWaygood AlexWaygood left review comments

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

+1 more reviewer

@sylee957 sylee957 sylee957 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pablogsal @miss-islington @bedevere-bot @terryjreedy @sylee957 @AlexWaygood