KEMBAR78
gh-105908: fix `barry_as_FLUFL` future import by thatbirdguythatuknownot · Pull Request #105909 · python/cpython · GitHub
Skip to content

gh-105908: fix barry_as_FLUFL future import #105909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 19, 2023
Merged

gh-105908: fix barry_as_FLUFL future import #105909

merged 6 commits into from
Jun 19, 2023

Conversation

@thatbirdguythatuknownot
Copy link
Contributor

@thatbirdguythatuknownot thatbirdguythatuknownot commented Jun 19, 2023 •
edited by bedevere-bot
Loading

In compiler_setup(), the flags parameter is a local struct that does not reflect changes to the pointer passed to new_compiler(). Fix by making the flags parameter a pointer to a struct instead of a struct.

@bedevere-bot bedevere-bot mentioned this pull request Jun 19, 2023
Closed
@iritkatriel
Copy link
Member

Is there no test for this?

@thatbirdguythatuknownot
Copy link
Contributor Author

Is there no test for this?

I'm currently adding it.

@thatbirdguythatuknownot @Eclips4
fix news markdown
6815da7 
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@iritkatriel
Copy link
Member

Thank you @thatbirdguythatuknownot .

@iritkatriel iritkatriel added the type-bug An unexpected behavior, bug, or error label Jun 19, 2023
@iritkatriel
Copy link
Member

@thatbirdguythatuknownot there is a test failure in the "Address sanitizer" test. Is it due to this PR?

@thatbirdguythatuknownot
Copy link
Contributor Author

@thatbirdguythatuknownot there is a test failure in the "Address sanitizer" test. Is it due to this PR?

It must be from flags = &_PyCompilerFlags_INIT. I could probably bring back the local_flags variable to prevent it.

@iritkatriel iritkatriel merged commit 28187a9 into python:main Jun 19, 2023
@sunmy2019
Copy link
Member

Thanks! This change makes sense.

@JelleZijlstra
Copy link
Member

Does this need to be backported to 3.12?

@JelleZijlstra JelleZijlstra added the needs backport to 3.12 only security fixes label Jun 20, 2023
@miss-islington
Copy link
Contributor

Thanks @thatbirdguythatuknownot for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-105930 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 20, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2023
@thatbirdguythatuknownot @miss-islington
pythongh-105908: fix barry_as_FLUFL future import (pythonGH-105909)
32335a2 
(cherry picked from commit 28187a9)

Co-authored-by: Crowthebird <78076854+thatbirdguythatuknownot@users.noreply.github.com>
JelleZijlstra pushed a commit that referenced this pull request Jun 20, 2023
@miss-islington @thatbirdguythatuknownot
[3.12] gh-105908: fix barry_as_FLUFL future import (GH-105909) (#10…
cc18a8b 
…5930)

(cherry picked from commit 28187a9)

Co-authored-by: Crowthebird <78076854+thatbirdguythatuknownot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 left review comments

@iritkatriel iritkatriel iritkatriel approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@thatbirdguythatuknownot @iritkatriel @sunmy2019 @JelleZijlstra @miss-islington @bedevere-bot @Eclips4