KEMBAR78
gh-106075: add `asyncio.taskgroups.__all__` to `asyncio.__all__` by jamestwebber · Pull Request #106090 · python/cpython · GitHub
Skip to content

gh-106075: add asyncio.taskgroups.__all__ to asyncio.__all__ #106090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 26, 2023
Merged

gh-106075: add asyncio.taskgroups.__all__ to asyncio.__all__ #106090

merged 6 commits into from
Jun 26, 2023

Conversation

@jamestwebber
Copy link
Contributor

@jamestwebber jamestwebber commented Jun 25, 2023 •
edited by bedevere-bot
Loading

Minor fix to what seemed to be an oversight in how __init__ was written. Everything else is added to __all__ except for this newer module.

  • Successfully ran tests for asyncio
  • Ran blurb.py to add a note and added myself to ACKS 🎉

I didn't modify the docs at all, I don't think that is necessary for this.

@bedevere-bot bedevere-bot mentioned this pull request Jun 25, 2023
Closed
@ghost
Copy link

ghost commented Jun 25, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

Eclips4
Eclips4 reviewed Jun 25, 2023
View reviewed changes
Eclips4
Eclips4 reviewed Jun 25, 2023
View reviewed changes
@kumaraditya303 kumaraditya303 enabled auto-merge (squash) June 26, 2023 07:19
@kumaraditya303 kumaraditya303 merged commit a12e8ff into python:main Jun 26, 2023
@miss-islington
Copy link
Contributor

Thanks @jamestwebber for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2023
@jamestwebber @kumaraditya303 @miss-islington
pythongh-106075: add asyncio.taskgroups.__all__ to asyncio.__all__ (
fb4a203 
pythonGH-106090)

(cherry picked from commit a12e8ff)

Co-authored-by: James Webber <jamestwebber@users.noreply.github.com>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot
Copy link

GH-106098 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 26, 2023
kumaraditya303 added a commit that referenced this pull request Jun 26, 2023
@miss-islington @jamestwebber @kumaraditya303
[3.12] gh-106075: add asyncio.taskgroups.__all__ to `asyncio.__all_…
8d5d60f 
…_` (GH-106090) (#106098)

gh-106075: add `asyncio.taskgroups.__all__` to `asyncio.__all__` (GH-106090)
(cherry picked from commit a12e8ff)

Co-authored-by: James Webber <jamestwebber@users.noreply.github.com>
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@jamestwebber jamestwebber deleted the patch-1 branch June 26, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@Eclips4 Eclips4 Eclips4 left review comments

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jamestwebber @miss-islington @bedevere-bot @kumaraditya303 @Eclips4