gh-106831: Fix NULL check of d2i_SSL_SESSION result in _ssl.c
#106832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
😆 ad95c72 Done, I've addressed your review. Thanks for the quick feedback 👍 |
vstinner
approved these changes
Jul 17, 2023
| const_p = senc; | ||
| newsession = d2i_SSL_SESSION(NULL, &const_p, slen); | ||
| if (session == NULL) { | ||
| if (newsession == NULL) { |
There was a problem hiding this comment.
Oh, now I see the typo! Previous, session was checked, but newsession must checked! Nicely spotted.
vstinner
added
needs backport to 3.11
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 17, 2023
…pythonGH-106832) (cherry picked from commit ebf2c56) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-106835 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 17, 2023
…pythonGH-106832) (cherry picked from commit ebf2c56) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-106836 is a backport of this pull request to the 3.11 branch. |
vstinner
pushed a commit
that referenced
this pull request
Jul 17, 2023
vstinner
pushed a commit
that referenced
this pull request
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vstinner you've recently commited to this module, would you have time to take a look at the fix I am proposing? :)
Modules/_ssl.c#106831