KEMBAR78
gh-106881: Check for linux/limits.h before including it by justdan6 · Pull Request #107397 · python/cpython · GitHub
Skip to content

gh-106881: Check for linux/limits.h before including it #107397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2023
Merged

gh-106881: Check for linux/limits.h before including it #107397

merged 3 commits into from
Jul 28, 2023

Conversation

@justdan6
Copy link
Contributor

@justdan6 justdan6 commented Jul 28, 2023 •
edited by bedevere-bot
Loading

Check for linux/limits.h before including it

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot bedevere-bot mentioned this pull request Jul 28, 2023
Closed
@ghost
Copy link

ghost commented Jul 28, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

erlend-aasland
erlend-aasland reviewed Jul 28, 2023
View reviewed changes
@justdan6 @erlend-aasland
Update Modules/posixmodule.c
b5220aa 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@erlend-aasland erlend-aasland requested a review from gpshead July 28, 2023 20:41
@gpshead gpshead added needs backport to 3.12 only security fixes needs backport to 3.11 only security fixes labels Jul 28, 2023
@gpshead gpshead merged commit 11c055f into python:main Jul 28, 2023
@miss-islington
Copy link
Contributor

Thanks @justdan6 for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @justdan6 and @gpshead, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 11c055f5ff1a353de6d2e77f2af24aaa782878ba 3.12

@miss-islington
Copy link
Contributor

Sorry, @justdan6 and @gpshead, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 11c055f5ff1a353de6d2e77f2af24aaa782878ba 3.11

@gpshead gpshead added the type-bug An unexpected behavior, bug, or error label Jul 28, 2023
justdan6 added a commit to justdan6/cpython that referenced this pull request Jul 28, 2023
@justdan6 @erlend-aasland
[3.12] pythongh-106881: Check for linux/limits.h before including it (p…
c4dba23 
…ython#107397)

* Check for linux/limits.h before including it

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
(cherry picked from commit 11c055f)
@bedevere-bot
Copy link

GH-107414 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 28, 2023
@bedevere-bot
Copy link

GH-107415 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 28, 2023
gpshead pushed a commit that referenced this pull request Jul 28, 2023
@justdan6 @erlend-aasland
[3.12] gh-106881: Check for linux/limits.h before including it (#107397…
80aebd5 
…) (#107414)

* Check for linux/limits.h before including it

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
(cherry picked from commit 11c055f)
gpshead pushed a commit that referenced this pull request Jul 28, 2023
@justdan6
[3.11] gh-106881: Check for linux/limits.h before including it (#107397…
4049c5d 
…) (#107415)

* [3.11] gh-106881: Check for linux/limits.h before including it (#107397)

* Check for linux/limits.h before including it

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
(cherry picked from commit 11c055f)

* Fix sphinx-lint error in NEWS entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

@gpshead gpshead

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@justdan6 @bedevere-bot @miss-islington @gpshead @erlend-aasland