GH-107724: Fix the signature of PY_THROW callback functions.
#107725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markshannon
added
needs backport to 3.12
carljm
reviewed
Aug 8, 2023
Co-authored-by: Carl Meyer <carl@oddbird.net>
carljm
approved these changes
Aug 8, 2023
|
Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
GH-107802 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 9, 2023
…ythonGH-107725) (cherry picked from commit 52fbcf6) Co-authored-by: Mark Shannon <mark@hotpy.org>
Yhg1s
pushed a commit
that referenced
this pull request
Aug 11, 2023
…GH-107725) (#107802) GH-107724: Fix the signature of `PY_THROW` callback functions. (GH-107725) (cherry picked from commit 52fbcf6) Co-authored-by: Mark Shannon <mark@hotpy.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes signature from
callback(code: CodeType, offset: int)tocallback(code: CodeType, offset: int, exc: BaseException)to match all the other exception callback functions.
PY_THROWis inconsistent with the other exception handling callbacks #107724