KEMBAR78
GH-109214: Convert _SAVE_CURRENT_IP to _SET_IP in tier 2 trace creation. by markshannon · Pull Request #110755 · python/cpython · GitHub
Skip to content

GH-109214: Convert _SAVE_CURRENT_IP to _SET_IP in tier 2 trace creation. #110755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2023
Merged

GH-109214: Convert _SAVE_CURRENT_IP to _SET_IP in tier 2 trace creation. #110755

merged 1 commit into from
Oct 12, 2023

Conversation

@markshannon
Copy link
Member

@markshannon markshannon commented Oct 12, 2023 •
edited
Loading

Translate _SAVE_CURRENT_IP to _SET_IP when creating the tier 2 trace.
A bit more efficient, but mainly tidier.

@bedevere-app bedevere-app bot mentioned this pull request Oct 12, 2023
Closed
brandtbucher
brandtbucher approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup.

@markshannon markshannon merged commit 19b7ead into python:main Oct 12, 2023
@markshannon markshannon deleted the set-ip-directly branch October 12, 2023 09:36
vstinner pushed a commit to vstinner/cpython that referenced this pull request Oct 12, 2023
@markshannon @vstinner
pythonGH-109214: Convert _SAVE_CURRENT_IP to _SET_IP in tier 2 trace …
8471b20 
…creation. (pythonGH-110755)
@brandtbucher
Copy link
Member

Hm, did we ever try actually running this? I'm seeing assertion errors on builds with uops turned on that bisect to this commit:

$ ./python -X uops
python: ./Include/cpython/cellobject.h:26: PyCell_GET: Assertion `PyCell_Check(op)' failed.
Aborted

@brandtbucher brandtbucher mentioned this pull request Oct 17, 2023
Merged
@gvanrossum gvanrossum mentioned this pull request Oct 18, 2023
Merged
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@markshannon @Glyphack
pythonGH-109214: Convert _SAVE_CURRENT_IP to _SET_IP in tier 2 trace …
1da6029 
…creation. (pythonGH-110755)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markshannon @brandtbucher