KEMBAR78
GH-111808: Make the default value for `test.support.infinite_recursion()` conditional on compiler optimizations by brettcannon · Pull Request #112223 · python/cpython · GitHub
Skip to content

GH-111808: Make the default value for test.support.infinite_recursion() conditional on compiler optimizations #112223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 17, 2023
Merged

GH-111808: Make the default value for test.support.infinite_recursion() conditional on compiler optimizations #112223

merged 3 commits into from
Nov 17, 2023

Conversation

@brettcannon
Copy link
Member

@brettcannon brettcannon commented Nov 17, 2023 •
edited by bedevere-app bot
Loading

@brettcannon
pythonGH-111808: Make the default value for `test.support.infinite_re…
840fcfc 
…cursion()` conditional on compiler optimizations
@brettcannon brettcannon requested a review from vstinner November 17, 2023 23:24
@brettcannon brettcannon self-assigned this Nov 17, 2023
@bedevere-app bedevere-app bot mentioned this pull request Nov 17, 2023
Closed
vstinner
vstinner reviewed Nov 17, 2023
View reviewed changes
@AlexWaygood AlexWaygood removed their request for review November 17, 2023 23:31
@brettcannon brettcannon mentioned this pull request Nov 17, 2023
Merged
vstinner
vstinner approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm not sure about test_richcmp and test_typing changes. But if the CIs are fine with it, I'm also fine with it :-) I rely on the CI for that ;-)

@brettcannon
Copy link
Member Author

I'm not sure about test_richcmp and test_typing changes.

Don't worry, I am since I merged the PRs that added them. 😁

@brettcannon brettcannon merged commit f489ace into python:main Nov 17, 2023
@brettcannon brettcannon deleted the lower-default-infinite_recursion branch November 17, 2023 23:52
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@brettcannon @vstinner @aisk
pythonGH-111808: Make the default value for `test.support.infinite_re…
cf95f61 
…cursion()` conditional on compiler optimizations (pythonGH-112223)

Co-authored-by: Victor Stinner <vstinner@python.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@brettcannon @vstinner @Glyphack
pythonGH-111808: Make the default value for `test.support.infinite_re…
d86a9ad 
…cursion()` conditional on compiler optimizations (pythonGH-112223)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees

@brettcannon brettcannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brettcannon @vstinner