gh-107944: Improve error message for getargs with bad keyword arguments #114792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
commented
Jan 31, 2024
| } | ||
| else { | ||
| PyErr_Format(PyExc_TypeError, | ||
| "%.200s%s got an unexpected keyword argument '%S'", |
There was a problem hiding this comment.
I made this error message match the one in ceval.c
|
I still need to do the |
pablogsal
reviewed
Jan 31, 2024
| with self.check_suggestion_includes(suggestion): | ||
| func(bluch=None) | ||
|
|
||
| def test_unexpected_keyword_suggestion_via_getargs(self): |
There was a problem hiding this comment.
Do you mind adding a explicit test for when the suggestion fails (the 'else' case in the conditional here
There was a problem hiding this comment.
Thanks for the review! I added this test.
I also made a similar edit in the vgetargskeywords code path and added tests.
pablogsal
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Very good work @hauntsaninja! Thanks for working on this
This looks great, I left some nit but please feel free to ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.