gh-114685: PyBuffer_FillInfo now raises on PyBUF_{READ,WRITE}
#114802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
force-pushed
the
issue-114685-fill-info
branch
from
350a6e7 to
7e480af
Compare
aisk
reviewed
Feb 1, 2024
Co-authored-by: AN Long <aisk@users.noreply.github.com>
There was a problem hiding this comment.
See #60198. PyBuffer_FillInfo() with NULL as exporter is a fragile thing.
There was a problem hiding this comment.
Thank you.
Yet one nitpick. The code relies on the fact that b"abc" still exists after returning from buffer_fill_info(). It is so in CPython, but this is an implementation detail. It would be more reliable to explicitly keep a reference to it:
source = b'abc'
...
buffer_fill_info(source, ...)
|
Thank you! I always learn a lot from your reviews, very helpful. |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_imp.get_frozen_objectpossible incorrect use ofPyBUF_READ#114685