KEMBAR78
gh-114271: Make `PyInterpreterState.threads.count` thread-safe in free-threaded builds by mpage · Pull Request #115093 · python/cpython · GitHub
Skip to content

Conversation

@mpage
Copy link
Contributor

@mpage mpage commented Feb 6, 2024

Use atomics to mutate PyInterpreterState.threads.count

@mpage mpage force-pushed the gh-114271-threads.count branch from b22b2f0 to 7274538 Compare February 6, 2024 17:37
@mpage mpage marked this pull request as ready for review February 6, 2024 19:12
@mpage
Copy link
Contributor Author

mpage commented Feb 6, 2024

@colesbury - Can you add the "skip news" label to this?

@mpage
Copy link
Contributor Author

mpage commented Feb 12, 2024

@colesbury - Would you take a look at this, please?

Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsnowcurrently ericsnowcurrently merged commit de7d67b into python:main Feb 12, 2024
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
…in free-threaded builds (pythongh-115093)

Use atomics to mutate PyInterpreterState.threads.count.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants