gh-115323: Add meaningful error message for using bytearray.extend with str #115332
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
@sobolevn Ok to merge? |
terryjreedy
added
needs backport to 3.11
|
Thanks @jayasting98 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…end with str (pythonGH-115332) Perform str check after TypeError is raised --------- (cherry picked from commit 948acd6) Co-authored-by: Jay Ting <65202977+jayasting98@users.noreply.github.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-115894 is a backport of this pull request to the 3.12 branch. |
…end with str (pythonGH-115332) Perform str check after TypeError is raised --------- (cherry picked from commit 948acd6) Co-authored-by: Jay Ting <65202977+jayasting98@users.noreply.github.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-115895 is a backport of this pull request to the 3.11 branch. |
…end with str (python#115332) Perform str check after TypeError is raised --------- Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
…end with str (python#115332) Perform str check after TypeError is raised --------- Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
…end with str (python#115332) Perform str check after TypeError is raised --------- Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
5 participants
Fixes #115323
strstr, with a more meaningful error message that says the string should be encoded