KEMBAR78
gh-117691: Add an appropriate stacklevel for PEP-706 tarfile deprecation warnings by AlexWaygood · Pull Request #117872 · python/cpython · GitHub
Skip to content

gh-117691: Add an appropriate stacklevel for PEP-706 tarfile deprecation warnings #117872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2024
Merged

gh-117691: Add an appropriate stacklevel for PEP-706 tarfile deprecation warnings #117872

merged 1 commit into from
Apr 16, 2024

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Apr 14, 2024 •
edited by bedevere-app bot
Loading

@AlexWaygood AlexWaygood added the needs backport to 3.12 only security fixes label Apr 14, 2024
@AlexWaygood AlexWaygood requested a review from encukou April 14, 2024 15:01
@bedevere-app bedevere-app bot mentioned this pull request Apr 14, 2024
Closed
encukou
encukou approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@encukou encukou merged commit cff0a2d into python:main Apr 16, 2024
@miss-islington-app
Copy link

Thanks @AlexWaygood for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 16, 2024
@AlexWaygood @miss-islington
pythongh-117691: Add an appropriate stacklevel for PEP-706 tarfile de…
dc92209 
…precation warnings (pythonGH-117872)

(cherry picked from commit cff0a2d)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 16, 2024

GH-117930 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 16, 2024
@AlexWaygood AlexWaygood deleted the tarfile-depr branch April 16, 2024 11:36
encukou pushed a commit that referenced this pull request Apr 16, 2024
@miss-islington @AlexWaygood
[3.12] gh-117691: Add an appropriate stacklevel for PEP-706 tarfile d…
aa26dc3 
…eprecation warnings (GH-117872) (GH-117930)

gh-117691: Add an appropriate stacklevel for PEP-706 tarfile deprecation warnings (GH-117872)
(cherry picked from commit cff0a2d)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@AlexWaygood @diegorusso
pythongh-117691: Add an appropriate stacklevel for PEP-706 tarfile de…
5a885a0 
…precation warnings (pythonGH-117872)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexWaygood @encukou