KEMBAR78
[3.12] gh-118272: Clear generator frame's locals when the generator is closed by iritkatriel · Pull Request #118451 · python/cpython · GitHub
Skip to content

[3.12] gh-118272: Clear generator frame's locals when the generator is closed #118451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2024
Merged

[3.12] gh-118272: Clear generator frame's locals when the generator is closed #118451

merged 2 commits into from
May 2, 2024

Conversation

@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Apr 30, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 30, 2024
Closed
@iritkatriel iritkatriel added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Apr 30, 2024
@iritkatriel iritkatriel changed the title gh-118272: Clear generator frame's locals when the generator is closed [3.12] gh-118272: Clear generator frame's locals when the generator is closed Apr 30, 2024
markshannon
markshannon requested changes May 1, 2024
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented May 1, 2024

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

And if you don't make the requested changes, you will be poked with soft cushions!

@iritkatriel
Copy link
Member Author

I have made the requested changes; please review again.

@bedevere-app
Copy link

bedevere-app bot commented May 1, 2024

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from markshannon May 1, 2024 17:16
@iritkatriel iritkatriel merged commit 238efbe into python:3.12 May 2, 2024
iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Jun 13, 2024
@iritkatriel
Revert "[3.12] pythongh-118272: Clear generator frame's locals when t…
8883db0 
…he generator is closed (python#118451)"

This reverts commit 238efbe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iritkatriel @markshannon