gh-119011: type.__type_params__ now return an empty tuple
#119296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested review from
JelleZijlstra,
markshannon and
rhettinger
as code owners
carljm
approved these changes
May 21, 2024
JelleZijlstra
added
needs backport to 3.12
JelleZijlstra
approved these changes
May 28, 2024
|
Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 28, 2024
…thonGH-119296) (cherry picked from commit 6b240c2) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
Sorry, @sobolevn and @JelleZijlstra, I could not cleanly backport this to |
|
GH-119678 is a backport of this pull request to the 3.13 branch. |
JelleZijlstra
pushed a commit
to JelleZijlstra/cpython
that referenced
this pull request
May 28, 2024
…ple (pythonGH-119296) (cherry picked from commit 6b240c2) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-119681 is a backport of this pull request to the 3.12 branch. |
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went ahead and implemented this special case.
I've also added
objectto the test, because it was missing and can also be quite important / different from other types.functools.update_wrapperdoes not work withtype#119011