KEMBAR78
gh-118908: Fix completions after namespace change in REPL by lysnikolaou · Pull Request #120370 · python/cpython · GitHub
Skip to content

gh-118908: Fix completions after namespace change in REPL #120370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2024
Merged

gh-118908: Fix completions after namespace change in REPL #120370

merged 1 commit into from
Jun 12, 2024

Conversation

@lysnikolaou
Copy link
Member

@lysnikolaou lysnikolaou commented Jun 11, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jun 11, 2024
Open
@pablogsal
Copy link
Member

Damn! Thanks for the catch 🖤

@lysnikolaou lysnikolaou added skip news needs backport to 3.13 bugs and security fixes topic-repl Related to the interactive shell labels Jun 11, 2024
@lysnikolaou lysnikolaou merged commit 02e74c3 into python:main Jun 12, 2024
@miss-islington-app
Copy link

Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@lysnikolaou lysnikolaou deleted the fix-completions-after-namespace-change branch June 12, 2024 08:21
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 12, 2024
@lysnikolaou @miss-islington
pythongh-118908: Fix completions after namespace change in REPL (pyth…
f7e572c 
…onGH-120370)

(cherry picked from commit 02e74c3)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 12, 2024

GH-120392 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 12, 2024
lysnikolaou added a commit that referenced this pull request Jun 12, 2024
@miss-islington @lysnikolaou
[3.13] gh-118908: Fix completions after namespace change in REPL (GH-…
10821cc 
…120370) (#120392)

(cherry picked from commit 02e74c3)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@lysnikolaou @mrahtz
pythongh-118908: Fix completions after namespace change in REPL (pyth…
f721d1d 
…on#120370)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@lysnikolaou @noahbkim
pythongh-118908: Fix completions after namespace change in REPL (pyth…
a115c21 
…on#120370)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@lysnikolaou @estyxx
pythongh-118908: Fix completions after namespace change in REPL (pyth…
4b5ad7e 
…on#120370)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees

No one assigned

Labels

skip news topic-repl Related to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lysnikolaou @pablogsal