KEMBAR78
gh-120388: Improve deprecation warning message, when test returns non-None by sobolevn · Pull Request #120401 · python/cpython · GitHub
Skip to content

gh-120388: Improve deprecation warning message, when test returns non-None #120401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 12, 2024
Merged

gh-120388: Improve deprecation warning message, when test returns non-None #120401

merged 7 commits into from
Jun 12, 2024

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Jun 12, 2024 •
edited by bedevere-app bot
Loading

New message:

DeprecationWarning: It is deprecated to return a value that is not None, got: (<class 'coroutine'>) from a test case (<bound method TestSpecial.test_some of <test.test_enum.TestSpecial testMethod=test_some>>); a coroutine is returned, maybe you forgot to use IsolatedAsyncioTestCase base class?
  return self.run(*args, **kwds)

@sobolevn sobolevn requested a review from ethanfurman as a code owner June 12, 2024 12:11
@bedevere-app bedevere-app bot mentioned this pull request Jun 12, 2024
Closed
AlexWaygood
AlexWaygood reviewed Jun 12, 2024
View reviewed changes
AlexWaygood
AlexWaygood reviewed Jun 12, 2024
View reviewed changes
AlexWaygood
AlexWaygood reviewed Jun 12, 2024
View reviewed changes
AlexWaygood
AlexWaygood approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks!

picnixz
picnixz reviewed Jun 12, 2024
View reviewed changes
serhiy-storchaka
serhiy-storchaka reviewed Jun 12, 2024
View reviewed changes
serhiy-storchaka
serhiy-storchaka approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sobolevn @serhiy-storchaka
Apply suggestions from code review
3a05159 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@sobolevn sobolevn enabled auto-merge (squash) June 12, 2024 14:14
@sobolevn sobolevn merged commit fabcf6b into python:main Jun 12, 2024
@serhiy-storchaka
Copy link
Member

Thanks, @sobolevn.

mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@sobolevn @AlexWaygood
@serhiy-storchaka @mrahtz
pythongh-120388: Improve deprecation warning message, when test retur…
86fc6c8 
…ns non-None (python#120401)

Co-authored-by: Alex Waygood <alex.waygood@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@sobolevn @AlexWaygood
@serhiy-storchaka @noahbkim
pythongh-120388: Improve deprecation warning message, when test retur…
c1877da 
…ns non-None (python#120401)

Co-authored-by: Alex Waygood <alex.waygood@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@sobolevn @AlexWaygood
@serhiy-storchaka @estyxx
pythongh-120388: Improve deprecation warning message, when test retur…
6f7dab3 
…ns non-None (python#120401)

Co-authored-by: Alex Waygood <alex.waygood@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@zware zware Awaiting requested review from zware

@ethanfurman ethanfurman Awaiting requested review from ethanfurman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn @serhiy-storchaka @picnixz @AlexWaygood