KEMBAR78
gh-120602: Support LLVM_VERSION_SUFFIX by xarblu · Pull Request #120604 · python/cpython · GitHub
Skip to content

gh-120602: Support LLVM_VERSION_SUFFIX #120604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2024
Merged

gh-120602: Support LLVM_VERSION_SUFFIX #120604

merged 1 commit into from
Jun 20, 2024

Conversation

@xarblu
Copy link
Contributor

@xarblu xarblu commented Jun 16, 2024 •
edited by bedevere-app bot
Loading

@xarblu xarblu requested a review from brandtbucher as a code owner June 16, 2024 21:10
@ghost
Copy link

ghost commented Jun 16, 2024 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Jun 16, 2024
Closed
@bedevere-app
Copy link

bedevere-app bot commented Jun 16, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

savannahostrowski
savannahostrowski approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@savannahostrowski savannahostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping the suffix piece of the regex flexible seems reasonable so this looks good to me, thanks!

brandtbucher
brandtbucher approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @xarblu!

@brandtbucher brandtbucher added build The build process and cross-build needs backport to 3.13 bugs and security fixes topic-JIT labels Jun 18, 2024
@brandtbucher
Copy link
Member

Can you add a NEWS entry? Just something simple, like:

Correctly handle LLVM installs with ``LLVM_VERSION_SUFFIX`` when building with ``--enable-experimental-jit``.

@xarblu xarblu force-pushed the llvm_version_suffix branch from 69e43a9 to 6c68903 Compare June 19, 2024 19:09
@xarblu
Copy link
Contributor Author

xarblu commented Jun 19, 2024 •
edited
Loading

@brandtbucher Just added your suggested news entry

EDIT: I assumed Build was the correct section as LLVM is (as far as I know) only used there. Let me know if that's not the case.

@brandtbucher brandtbucher merged commit 285f42c into python:main Jun 20, 2024
@miss-islington-app
Copy link

Thanks @xarblu for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2024
@xarblu @miss-islington
pythonGH-120602: Support LLVM_VERSION_SUFFIX for JIT builds (pythonGH…
84cbf60 
…-120604)

(cherry picked from commit 285f42c)

Co-authored-by: Xarblu <xarblu@protonmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 20, 2024

GH-120768 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 20, 2024
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@xarblu @mrahtz
pythonGH-120602: Support LLVM_VERSION_SUFFIX for JIT builds (pythonGH…
24b8cbb 
…-120604)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@xarblu @noahbkim
pythonGH-120602: Support LLVM_VERSION_SUFFIX for JIT builds (pythonGH…
48e364c 
…-120604)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@xarblu @estyxx
pythonGH-120602: Support LLVM_VERSION_SUFFIX for JIT builds (pythonGH…
05290cc 
…-120604)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@savannahostrowski savannahostrowski savannahostrowski approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees

No one assigned

Labels

build The build process and cross-build topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xarblu @brandtbucher @savannahostrowski