KEMBAR78
gh-121163: Add support for ``all`` as an valid alias for ``always`` in ``warnings.simplefilter`` and ``warnings.filterswarnings`` by Eclips4 · Pull Request #121164 · python/cpython · GitHub
Skip to content

Conversation

@Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Jun 29, 2024

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It makes sense to support -Wall which is commonly used in GCC/clang. And making it as alias to "always" makes sense to "all" means showing "all" warnings. "default" or "once" would not fit -Wall.

Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit 1a84bdc into python:main Jun 30, 2024
@vstinner
Copy link
Member

Merged, thanks.

@Eclips4 Eclips4 deleted the issue-121163 branch June 30, 2024 17:48
hauntsaninja added a commit to hauntsaninja/cpython that referenced this pull request Jul 7, 2024
This was introduced in python#121164
and appears to be causing test failures on main
hauntsaninja added a commit that referenced this pull request Jul 8, 2024
This was introduced in #121164
and appears to be causing test failures on main
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
….simplefilter() (python#121164)

Add support for ``all`` as an valid alias for ``always`` in ``warnings.simplefilter()``
and ``warnings.filterswarnings()``.
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
This was introduced in python#121164
and appears to be causing test failures on main
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
….simplefilter() (python#121164)

Add support for ``all`` as an valid alias for ``always`` in ``warnings.simplefilter()``
and ``warnings.filterswarnings()``.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
This was introduced in python#121164
and appears to be causing test failures on main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants