KEMBAR78
gh-117139: Fix an incorrect borrow in bytecodes.c by colesbury · Pull Request #122318 · python/cpython · GitHub
Skip to content

Conversation

@colesbury
Copy link
Contributor

@colesbury colesbury commented Jul 26, 2024

_PyDict_SetItem_Take2 steals both the key (i.e., sub) and the value.

`_PyDict_SetItem_Take2` steals both the key (i.e., `sub`) and the value.
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303 kumaraditya303 merged commit 674a50e into python:main Aug 7, 2024
@colesbury colesbury deleted the gh-117139-fix-steal branch August 7, 2024 14:45
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
`_PyDict_SetItem_Take2` steals both the key (i.e., `sub`) and the value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants