gh-123572: Fix key codes in VK_MAP in windows_console.py #122692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
changed the title
|
Can you please add a NEWS entry? you can use the formulation of #123573 if you want. |
|
@devdanzin I have pushed a news entry for you. Next time you can do as @picnixz indicates or using the blu tool. |
pablogsal
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
LGTM
Thanks for the PR @devdanzin and @picnixz for the review!
|
(I haven't done much :') but thanks for the thanks) |
|
Thanks @devdanzin for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 3, 2024
…nGH-122692) (cherry picked from commit 782217f) Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>
|
GH-123632 is a backport of this pull request to the 3.13 branch. |
pablogsal
pushed a commit
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This trivial PR corrects a couple Virtual-Key Codes found in
VK_MAPin windows_console.py. It should have no impact on real use of the new REPL, as AFAIK those VKs are unused.cc @DinoV