KEMBAR78
Ensure that iOS test re-runs don't try to spawn a process. by freakboy3742 · Pull Request #122994 · python/cpython · GitHub
Skip to content

Ensure that iOS test re-runs don't try to spawn a process. #122994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2024
Merged

Ensure that iOS test re-runs don't try to spawn a process. #122994

merged 1 commit into from
Aug 14, 2024

Conversation

@freakboy3742
Copy link
Contributor

@freakboy3742 freakboy3742 commented Aug 14, 2024 •
edited
Loading

#122992 added a --rerun option to the iOS testbed... which was then exercised on the run merging to main, revealing that --rerun reruns in a subprocess by default.

This PR also enables the --single-process option, ensuring that reruns are executed in the same process.

@freakboy3742 freakboy3742 requested a review from ned-deily August 14, 2024 01:20
@freakboy3742
Copy link
Contributor Author

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit b3a9e63 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@freakboy3742 freakboy3742 mentioned this pull request Aug 14, 2024
Merged
@freakboy3742 freakboy3742 merged commit e03073f into python:main Aug 14, 2024
@freakboy3742 freakboy3742 deleted the ios-retry-singleprocess branch August 14, 2024 01:46
@freakboy3742 freakboy3742 mentioned this pull request Aug 14, 2024
Merged
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@freakboy3742 @blhsing
Ensure that iOS test re-runs don't try to spawn a process. (python#12…
8e7279b 
…2994)

Adds the --single-process option to the iOS test runner to ensure re-runs execute in the same process.
@freakboy3742 freakboy3742 added the needs backport to 3.13 bugs and security fixes label Aug 27, 2024
@miss-islington-app
Copy link

Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 27, 2024
@freakboy3742 @miss-islington
Ensure that iOS test re-runs don't try to spawn a process. (pythonGH-…
b634ddd 
…122994)

Adds the --single-process option to the iOS test runner to ensure re-runs execute in the same process.
(cherry picked from commit e03073f)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 27, 2024

GH-123368 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 27, 2024
freakboy3742 added a commit that referenced this pull request Aug 27, 2024
@miss-islington @freakboy3742
[3.13] Ensure that iOS test re-runs don't try to spawn a process. (GH…
fa21b3b 
…-122994) (#123368)

Ensure that iOS test re-runs don't try to spawn a process. (GH-122994)

Adds the --single-process option to the iOS test runner to ensure re-runs execute in the same process.
(cherry picked from commit e03073f)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

Assignees

No one assigned

Labels

OS-ios skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@freakboy3742 @bedevere-bot @ned-deily