gh-104860: Fix allow_abbrev=False for single-dash long options #124340
Conversation
serhiy-storchaka
added
needs backport to 3.12
There was a problem hiding this comment.
The change LGTM but I didn't approve the PR since I don't know well argparse code base. The test covers the changed code.
I'm not sure if we should backport the change since it changes the behavior which is there since Python 3.8. Even if it's a bug, users may rely on the current behavior.
|
I think this is pretty safe change. It makes the code working as it is supposed to work, as it is documented, and as it worked it the past. If you do not want to disallow abbreviation, just do not use |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
serhiy-storchaka
deleted the
argparse-disallow-single-dash-long-abbrev
branch
…ythonGH-124340) (cherry picked from commit 49e105f) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-124749 is a backport of this pull request to the 3.13 branch. |
…ythonGH-124340) (cherry picked from commit 49e105f) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-124750 is a backport of this pull request to the 3.12 branch. |
…GH-124340) (GH-124750) (cherry picked from commit 49e105f) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
…GH-124340) (GH-124749) (cherry picked from commit 49e105f) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
2 participants
Uh oh!
There was an error while loading. Please reload this page.