gh-124787: Fix TypeAliasType and incorrect type_params
#124795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested review from
JelleZijlstra and
markshannon
as code owners
Daraan
added a commit
to Daraan/typing_extensions
that referenced
this pull request
Sep 30, 2024
3 tasks
JelleZijlstra
approved these changes
Oct 8, 2024
Misc/NEWS.d/next/Library/2024-09-30-20-46-32.gh-issue-124787.3FnJnP.rst
Outdated
Show resolved
Hide resolved
|
!buildbot refleak |
|
🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 7d439f8 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
…FnJnP.rst Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
Refleaks are green 🎉 |
|
@JelleZijlstra what do you think: is this a bug fix or a new feature? Should we backport this to 3.12 and 3.13? |
|
To me this feels too risky to backport; let's apply it to 3.14 only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.