gh-125221: Fix free-threading data race in object.__reduce_ex__
#125267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lazy initialization of `objreduce` wasn't thread-safe in the free threading build. Instead, initialize the interpreter's cached `objreduce` field as part of the initialization of interpreter's types.
colesbury
added
topic-free-threading
needs backport to 3.13
kumaraditya303
approved these changes
Oct 11, 2024
|
Thanks @colesbury for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 11, 2024
…_` (pythonGH-125267) (cherry picked from commit b12e992) Co-authored-by: Sam Gross <colesbury@gmail.com>
|
GH-125305 is a backport of this pull request to the 3.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lazy initialization of
objreducewasn't thread-safe in the free threading build. Instead, initialize the interpreter's cachedobjreducefield as part of the initialization of interpreter's types.