gh-128078: Simplify logic in _PyGen_SetStopIterationValue (follow-up to gh-128780)
#128287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
changed the title
StopIteration-like exceptions in _PyGen_SetStopIterationValueStopAsyncIteration in _PyGen_SetStopIterationValue
picnixz
added
needs backport to 3.12
|
Instead of adding another special case, how about removing the special case for tuples? Maybe use |
|
@markshannon Is this something like that you had in mind? |
picnixz
changed the title
StopAsyncIteration in _PyGen_SetStopIterationValue_PyGen_SetStopIterationValue (follow-up to gh-128780)
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
kumaraditya303
approved these changes
Jan 13, 2025
|
Thanks @picnixz for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 13, 2025
…rationValue` (pythonGH-128287) (cherry picked from commit 402b91d) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
|
GH-128789 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 13, 2025
…rationValue` (pythonGH-128287) (cherry picked from commit 402b91d) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
|
GH-128790 is a backport of this pull request to the 3.12 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some calls have aStopAsyncIterationexception set at this point but we should ignore them since this function is meant to create aStopIterationinstead (or replace an existingStopAsyncIteration)Alternative I have also envisaged:
- Unconditionally clear an optional caller's exception: this would be probably fine but this could hide bugs.- Also clearStopIteration: strictly speaking I think we could also do it but as I'm not extremely familiar with the call graph, I'd prefer restricting it toStopAsyncIterationfor now.Following #128780, no need for checking whether an exception is set or not as no exception should be set at all. So we can simplify the logic.