KEMBAR78
gh-129958: Properly disallow newlines in format specs in single-quoted f-strings by pablogsal · Pull Request #130063 · python/cpython · GitHub
Skip to content

gh-129958: Properly disallow newlines in format specs in single-quoted f-strings #130063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

gh-129958: Properly disallow newlines in format specs in single-quoted f-strings #130063

merged 1 commit into from
Apr 18, 2025

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Feb 13, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 13, 2025
Closed
@ambv ambv added the needs backport to 3.13 bugs and security fixes label Apr 18, 2025
@ambv ambv merged commit 2f8b08d into python:main Apr 18, 2025
46 checks passed
@miss-islington-app
Copy link

Thanks @pablogsal for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @pablogsal and @ambv, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 2f8b08da475152adea59b6bf98e2d0cb73dd8a59 3.13

ambv pushed a commit to ambv/cpython that referenced this pull request Apr 18, 2025
@pablogsal @ambv
[3.13] pythongh-129958: Properly disallow newlines in format specs in…
de0c4cf 
… single-quoted f-strings (pythonGH-130063)

(cherry picked from commit 2f8b08d)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 18, 2025

GH-132692 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 18, 2025
ambv added a commit that referenced this pull request Apr 18, 2025
@ambv @pablogsal
[3.13] gh-129958: Properly disallow newlines in format specs in singl…
a37d719 
…e-quoted f-strings (GH-130063) (GH-132692)

(cherry picked from commit 2f8b08d)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

@ambv ambv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pablogsal @ambv