KEMBAR78
gh-130637: Add validation for numeric response data in `stat()` method by Mr-Sunglasses · Pull Request #130646 · python/cpython · GitHub
Skip to content

gh-130637: Add validation for numeric response data in stat() method #130646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 2, 2025
Merged

gh-130637: Add validation for numeric response data in stat() method #130646

merged 7 commits into from
Mar 2, 2025

Conversation

@Mr-Sunglasses
Copy link
Contributor

@Mr-Sunglasses Mr-Sunglasses commented Feb 27, 2025 •
edited by bedevere-app bot
Loading

@Mr-Sunglasses Mr-Sunglasses requested a review from a team as a code owner February 27, 2025 18:17
@bedevere-app bedevere-app bot mentioned this pull request Feb 27, 2025
Closed
Mr-Sunglasses
Mr-Sunglasses commented Feb 27, 2025
View reviewed changes
Copy link
Contributor Author

@Mr-Sunglasses Mr-Sunglasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bug, i think it did not need a NEWS entry.

@ericvsmith
Copy link
Member

This needs tests.

@Mr-Sunglasses
Copy link
Contributor Author

This needs tests.

Hey @ericvsmith I've added then tests Thanks for the suggestion, Please Review it

Mr-Sunglasses
Mr-Sunglasses commented Feb 28, 2025
View reviewed changes
Copy link
Contributor Author

@Mr-Sunglasses Mr-Sunglasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

== Tests result: FAILURE ==

1 test altered the execution environment (env changed):
    test_ssl

1 test failed:
    test_importlib

23 tests OK.

Total duration: 5 min 25 sec
Total tests: run=6,169 failures=1 skipped=192
Total test files: run=25/25 failed=1 env_changed=1
Result: FAILURE
Error: Process completed with exit code 2.

This test is failing and I think it is not related to the changes in this PR.

ericvsmith
ericvsmith requested changes Feb 28, 2025
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented Feb 28, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ericvsmith
Copy link
Member

Also, I don't agree that there shouldn't be a NEWS entry. We put bug fixes in NEWS all the time.

@Mr-Sunglasses
Copy link
Contributor Author

@ericvsmith I have made the requested changes; please review again.

@bedevere-app
Copy link

bedevere-app bot commented Feb 28, 2025

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from ericvsmith February 28, 2025 20:58
@Mr-Sunglasses
Copy link
Contributor Author

Also, I don't agree that there shouldn't be a NEWS entry. We put bug fixes in NEWS all the time.

Add the NEWS entry, thanks.

@ericvsmith ericvsmith added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed skip news labels Mar 1, 2025
ericvsmith
ericvsmith approved these changes Mar 1, 2025
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericvsmith ericvsmith merged commit a42168d into python:main Mar 2, 2025
39 checks passed
@miss-islington-app
Copy link

Thanks @Mr-Sunglasses for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2025
@Mr-Sunglasses @ericvsmith @miss-islington
pythongh-130637: Add validation for numeric response data in stat()…
bbab776 
… method (pythonGH-130646)

(cherry picked from commit a42168d)

Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 2, 2025

GH-130763 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 2, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2025
@Mr-Sunglasses @ericvsmith @miss-islington
pythongh-130637: Add validation for numeric response data in stat()…
9148113 
… method (pythonGH-130646)

(cherry picked from commit a42168d)

Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 2, 2025

GH-130764 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 2, 2025
terryjreedy pushed a commit that referenced this pull request Mar 2, 2025
@miss-islington @Mr-Sunglasses @ericvsmith
[3.12] gh-130637: Add validation for numeric response data in `stat()…
d9ca98a 
…` method (GH-130646) (#130764)

gh-130637: Add validation for numeric response data in `stat()` method (GH-130646)
(cherry picked from commit a42168d)

Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
terryjreedy pushed a commit that referenced this pull request Mar 2, 2025
@miss-islington @Mr-Sunglasses @ericvsmith
[3.13] gh-130637: Add validation for numeric response data in `stat()…
e6dfa9d 
…` method (GH-130646) (#130763)

gh-130637: Add validation for numeric response data in `stat()` method (GH-130646)
(cherry picked from commit a42168d)

Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@Mr-Sunglasses @ericvsmith @seehwan80
pythongh-130637: Add validation for numeric response data in stat()…
a00022c 
… method (python#130646)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

poplib.py: Missing integer parsing validation causes client crash on invalid server response

3 participants

@Mr-Sunglasses @ericvsmith @skirpichev