KEMBAR78
gh-111178: Fix function signatures of unicodeiter by vstinner · Pull Request #130684 · python/cpython · GitHub
Skip to content

gh-111178: Fix function signatures of unicodeiter #130684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2025
Merged

gh-111178: Fix function signatures of unicodeiter #130684

merged 2 commits into from
Mar 4, 2025

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Feb 28, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 28, 2025
Closed
picnixz
picnixz reviewed Feb 28, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still UBSan failures, e.g., unicodeiter_len and unicodeiter_reduce. Could you change them as well? TiA.

@vstinner
Copy link
Member Author

There are still UBSan failures, e.g., unicodeiter_len and unicodeiter_reduce. Could you change them as well? TiA.

Oh, I missed these functions. I updated them as well. Please take another look.

@vstinner vstinner merged commit ed8675c into python:main Mar 4, 2025
41 checks passed
@vstinner vstinner deleted the ubsan_unicodeiter branch March 4, 2025 09:33
@picnixz
Copy link
Member

picnixz commented Mar 4, 2025

Please take another look

I forgot to have a look... sorry :(

@picnixz
Copy link
Member

picnixz commented Mar 4, 2025

When I forget, please don't hesistate to request a review or ping me on Discord!

seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@vstinner @seehwan80
pythongh-111178: Fix function signatures of unicodeiter (python#130684)
8af44ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @picnixz