KEMBAR78
gh-130453: pygettext: Allow overriding default keywords when using `--keyword` by tomasr8 · Pull Request #130709 · python/cpython · GitHub
Skip to content

gh-130453: pygettext: Allow overriding default keywords when using --keyword #130709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2025
Merged

gh-130453: pygettext: Allow overriding default keywords when using --keyword #130709

merged 2 commits into from
Mar 3, 2025

Conversation

@tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Feb 28, 2025 •
edited by bedevere-app bot
Loading

Related comment: #130453 (comment)

Both babel and xgettext allow this. For example for xgettext --keyword='_:1,2' and this input file

_('foo', 'foos', 1)

xgettext will extract

msgid "foo"
msgid_plural "foos"
msgstr[0] ""
msgstr[1] ""

while pygettext will extract

msgid "foo"
msgstr ""

i.e. the default keyword takes precedence. It should be possible to use --keyword to override the default keyword (_:1) same as xgettext and babel.

@bedevere-app bedevere-app bot mentioned this pull request Feb 28, 2025
Open
serhiy-storchaka
serhiy-storchaka approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka merged commit 321bf59 into python:main Mar 3, 2025
45 checks passed
@tomasr8 tomasr8 deleted the pygettext-precedence branch March 3, 2025 20:10
@tomasr8 tomasr8 mentioned this pull request Mar 17, 2025
Merged
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@tomasr8 @seehwan80
pythongh-130453: pygettext: Allow overriding default keywords when us…
4701486 
…ing `--keyword` (pythonGH-130709)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomasr8 @serhiy-storchaka