KEMBAR78
gh-111178: Fix function signatures for test_capi by vstinner · Pull Request #131659 · python/cpython · GitHub
Skip to content

gh-111178: Fix function signatures for test_capi #131659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 24, 2025
Merged

gh-111178: Fix function signatures for test_capi #131659

merged 3 commits into from
Mar 24, 2025

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Mar 24, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 24, 2025
Closed
picnixz
picnixz approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be consistent with the rest of your added code and the existing code (for *const *args). Btw, just check if you need to remove redundant casts for the affected functions.

vstinner and others added 2 commits March 24, 2025 14:33
@vstinner @picnixz
Apply suggestions from code review
e5e7b2e 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@vstinner
Merge branch 'main' into ubsan_test_capi
8adef75
@vstinner
Copy link
Member Author

Just to be consistent with the rest of your added code and the existing code (for *const *args).

I applied your suggestions.

Btw, just check if you need to remove redundant casts for the affected functions.

Done: I checked all modified functions. There was no cast before.

@vstinner vstinner enabled auto-merge (squash) March 24, 2025 13:41
@vstinner vstinner merged commit 6226edc into python:main Mar 24, 2025
41 checks passed
@vstinner vstinner deleted the ubsan_test_capi branch March 24, 2025 14:04
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 1, 2025
@vstinner @picnixz @diegorusso
pythongh-111178: Fix function signatures for test_capi (python#131659)
0fee029 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@vstinner @picnixz @seehwan80
pythongh-111178: Fix function signatures for test_capi (python#131659)
5db2022 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @picnixz