KEMBAR78
gh-133194: Fix regression with PEP 758 parsing on older `feature_version` by sobolevn · Pull Request #133289 · python/cpython · GitHub
Skip to content

gh-133194: Fix regression with PEP 758 parsing on older feature_version #133289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2025
Merged

gh-133194: Fix regression with PEP 758 parsing on older feature_version #133289

merged 1 commit into from
May 3, 2025

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented May 2, 2025 •
edited
Loading

My previous change was not quite correct in two ways:

  • minor: missing "are" in the exception message
  • major: it stopped allowing parsing valid code like except TypeError: with older feature_versions :(

I added a lot more tests and fixed the problem (hopefully)! Reviews are highly appreciated 🙏

Fixes #133195
Fixes #133194
cc @cdce8p

@sobolevn sobolevn changed the title gh-133192: Fix regression with PEP 758 parsing on older feature_version gh-133194: Fix regression with PEP 758 parsing on older feature_version May 2, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 2, 2025
Closed
cdce8p
cdce8p approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @sobolevn for picking this up so quickly 🙏🏻

lysnikolaou
lysnikolaou approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks good to me! Missed it in the earlier PR. Surprised that the tests didn't catch it.

@sobolevn
Copy link
Member Author

sobolevn commented May 2, 2025

I will keep this open for a day, so maybe @pablogsal can also comment.

Thanks everyone 👍

@sobolevn sobolevn merged commit ca0a96d into python:main May 3, 2025
49 checks passed
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@sobolevn @Pranjal095
pythongh-133194: Fix regression with PEP 758 parsing on older `featur…
75e6788 
…e_version` (python#133289)

pythongh-133192: Fix regression with PEP 758 parsing on older `feature_version`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

+1 more reviewer

@cdce8p cdce8p cdce8p approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PEP 758 changes do not have CHECK_VERSION guard for usage with ast.parse(..., feature_version=(3, 13))

4 participants

@sobolevn @lysnikolaou @cdce8p @Eclips4