KEMBAR78
gh-133300: argparse: make `suggest_on_error` a keyword-only parameter by hugovk · Pull Request #133302 · python/cpython · GitHub
Skip to content

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented May 2, 2025

Copy link
Member

@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! suggest_on_error is new in 3.14 so we can safely make this change.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hugovk hugovk merged commit e6c518d into python:main May 2, 2025
45 of 48 checks passed
@hugovk hugovk deleted the 3.14-argparse-keyword branch May 2, 2025 15:11
edgarrmondragon added a commit to edgarrmondragon/typeshed that referenced this pull request May 6, 2025
These are

- `suggest_on_error`, added by python/cpython#124456, made keyword-only by python/cpython#133302
- `color`, added by python/cpython#132323
JelleZijlstra added a commit to python/typeshed that referenced this pull request May 12, 2025
…13947)

These are

- `suggest_on_error`, added by python/cpython#124456, made keyword-only by python/cpython#133302
- `color`, added by python/cpython#132323

Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
mmingyu pushed a commit to mmingyu/typeshed that referenced this pull request May 16, 2025
…ython#13947)

These are

- `suggest_on_error`, added by python/cpython#124456, made keyword-only by python/cpython#133302
- `color`, added by python/cpython#132323

Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants