KEMBAR78
gh-133253: making linecache thread-safe by vfdev-5 · Pull Request #133305 · python/cpython · GitHub
Skip to content

Conversation

@vfdev-5
Copy link
Contributor

@vfdev-5 vfdev-5 commented May 2, 2025

Fixes #133253

Description:

  • Making linecache thread-safe

cc @colesbury

@python-cla-bot
Copy link

python-cla-bot bot commented May 2, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented May 2, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link
Contributor

@hawkinsp hawkinsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider checking in your tests, somewhere?

@vfdev-5 vfdev-5 force-pushed the make-linecache-threadsafe branch from a19749b to 67bfa7d Compare May 2, 2025 20:16
@bedevere-app
Copy link

bedevere-app bot commented May 2, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@vfdev-5 vfdev-5 force-pushed the make-linecache-threadsafe branch 3 times, most recently from 690f5a8 to ff93d54 Compare May 5, 2025 10:46
@vfdev-5 vfdev-5 marked this pull request as ready for review May 5, 2025 10:46
@vfdev-5
Copy link
Contributor Author

vfdev-5 commented May 5, 2025

@rhettinger could you please review this PR fixing the data race in linecache (issue 133253) or suggest a right person for the code review. Thanks!

@colesbury colesbury requested a review from rhettinger May 5, 2025 15:46
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I'd appreciate @rhettinger's review

@vfdev-5 vfdev-5 force-pushed the make-linecache-threadsafe branch from ff93d54 to f4fe446 Compare May 5, 2025 19:21
@kumaraditya303 kumaraditya303 merged commit 8054184 into python:main May 9, 2025
39 checks passed
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
Co-authored-by: Sam Gross <colesbury@gmail.com>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Co-authored-by: Sam Gross <colesbury@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Race in linecache under free-threading

4 participants