KEMBAR78
gh-77065: Use `putwch` instead of `putch` in `win_getpass` by donBarbos · Pull Request #134058 · python/cpython · GitHub
Skip to content

gh-77065: Use putwch instead of putch in win_getpass #134058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

gh-77065: Use putwch instead of putch in win_getpass #134058

merged 1 commit into from
May 15, 2025

Conversation

@donBarbos
Copy link
Contributor

@donBarbos donBarbos commented May 15, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 15, 2025
Closed
@donBarbos
Copy link
Contributor Author

I just got Windows today to run the tests, and only now figured out how to compile python

and now I'm ashamed that we have to send patches for one PR

picnixz
picnixz reviewed May 15, 2025
View reviewed changes
@picnixz picnixz enabled auto-merge (squash) May 15, 2025 15:04
@picnixz picnixz merged commit 52a7a22 into python:main May 15, 2025
52 checks passed
@miss-islington-app
Copy link

Thanks @donBarbos for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 15, 2025
@donBarbos @miss-islington
pythongh-77065: Use putwch instead of putch in `getpass.win_getpa…
4be874e 
…ss` (pythonGH-134058)

(cherry picked from commit 52a7a22)

Co-authored-by: Semyon Moroz <donbarbos@proton.me>
@bedevere-app
Copy link

bedevere-app bot commented May 15, 2025

GH-134059 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 15, 2025
picnixz pushed a commit that referenced this pull request May 15, 2025
@miss-islington @donBarbos
[3.14] gh-77065: Use putwch instead of putch in `getpass.win_getp…
438f464 
…ass` (GH-134058) (#134059)

gh-77065: Use `putwch` instead of `putch` in `getpass.win_getpass` (GH-134058)
(cherry picked from commit 52a7a22)

Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@donBarbos @Pranjal095
pythongh-77065: Use putwch instead of putch in `getpass.win_getpa…
bfcdf88 
…ss` (python#134058)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@donBarbos @taegyunkim
pythongh-77065: Use putwch instead of putch in `getpass.win_getpa…
ffb5d41 
…ss` (python#134058)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@donBarbos @picnixz