KEMBAR78
gh-134323: Fix the new `threading.RLock.locked` method by YvesDup · Pull Request #134368 · python/cpython · GitHub
Skip to content

gh-134323: Fix the new threading.RLock.locked method #134368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 22, 2025
Merged

gh-134323: Fix the new threading.RLock.locked method #134368

merged 10 commits into from
May 22, 2025

Conversation

@YvesDup
Copy link
Contributor

@YvesDup YvesDup commented May 20, 2025 •
edited
Loading

This method should call the private locked method of _block attribute instead the private _count attribute which is reserved for counting recursive call of acquire/release.

The fix also concerns the _thread module in the rlock_locked function.

@bedevere-app bedevere-app bot mentioned this pull request May 20, 2025
Closed
@colesbury colesbury requested a review from mpage May 20, 2025 20:43
colesbury
colesbury reviewed May 20, 2025
View reviewed changes
vstinner
vstinner reviewed May 20, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @sobolevn who added this locked() method.

kumaraditya303
kumaraditya303 reviewed May 21, 2025
View reviewed changes
kumaraditya303
kumaraditya303 reviewed May 21, 2025
View reviewed changes
YvesDup and others added 2 commits May 21, 2025 18:15
@YvesDup
Merge branch 'main' into rlock-threading-locked-failed
2603d50
@YvesDup @kumaraditya303
Fix nit
a0082a3 
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
colesbury
colesbury reviewed May 21, 2025
View reviewed changes
vstinner
vstinner reviewed May 21, 2025
View reviewed changes
vstinner
vstinner reviewed May 22, 2025
View reviewed changes
vstinner
vstinner approved these changes May 22, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the multiple updates :-)

@vstinner vstinner added the needs backport to 3.14 bugs and security fixes label May 22, 2025
@vstinner vstinner enabled auto-merge (squash) May 22, 2025 13:45
@vstinner vstinner merged commit 3effede into python:main May 22, 2025
45 checks passed
@miss-islington-app
Copy link

Thanks @YvesDup for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2025
@YvesDup @kumaraditya303 @miss-islington
pythongh-134323: Fix the new threading.RLock.locked method (pythonG…
3e871a1 
…H-134368)

(cherry picked from commit 3effede)

Co-authored-by: Duprat <yduprat@gmail.com>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@bedevere-app
Copy link

bedevere-app bot commented May 22, 2025

GH-134510 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 22, 2025
@vstinner
Copy link
Member

Merged, thanks for the fix.

vstinner pushed a commit that referenced this pull request May 22, 2025
@miss-islington @YvesDup @kumaraditya303
[3.14] gh-134323: Fix the new threading.RLock.locked method (GH-134368
ced49a1 
) (#134510)

gh-134323: Fix the new `threading.RLock.locked` method (GH-134368)
(cherry picked from commit 3effede)

Co-authored-by: Duprat <yduprat@gmail.com>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@YvesDup
Copy link
Contributor Author

YvesDup commented May 22, 2025

LGTM. Thanks for the multiple updates :-)

Thank's all for your comments

@YvesDup YvesDup deleted the rlock-threading-locked-failed branch May 22, 2025 16:15
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
@YvesDup @kumaraditya303 @lkollar
pythongh-134323: Fix the new threading.RLock.locked method (python#…
3d98861 
…134368)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@YvesDup @kumaraditya303 @Pranjal095
pythongh-134323: Fix the new threading.RLock.locked method (python#…
36fa14c 
…134368)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@YvesDup @kumaraditya303 @taegyunkim
pythongh-134323: Fix the new threading.RLock.locked method (python#…
5f4404b 
…134368)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury left review comments

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

@vstinner vstinner vstinner approved these changes

@mpage mpage Awaiting requested review from mpage

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@YvesDup @vstinner @colesbury @kumaraditya303