gh-135759: consistently reject negative sizes in SHAKE digests #135767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!buildbot FIPS only |
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit d968baa 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135767%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
blockchainGuru1018
approved these changes
Jun 20, 2025
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…ython#135767) Passing a negative digest length to `_hashilb.HASHXOF.[hex]digest()` now raises a ValueError instead of a MemoryError or a SystemError. This makes the behavior consistent with that of `_sha3.shake_{128,256}.[hex]digest`.
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…ython#135767) Passing a negative digest length to `_hashilb.HASHXOF.[hex]digest()` now raises a ValueError instead of a MemoryError or a SystemError. This makes the behavior consistent with that of `_sha3.shake_{128,256}.[hex]digest`.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…ython#135767) Passing a negative digest length to `_hashilb.HASHXOF.[hex]digest()` now raises a ValueError instead of a MemoryError or a SystemError. This makes the behavior consistent with that of `_sha3.shake_{128,256}.[hex]digest`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.