KEMBAR78
gh-136203: Improve `TypeError` msg when comparing two `MappingProxyType`s by sobolevn · Pull Request #136204 · python/cpython · GitHub
Skip to content

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 2, 2025

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just have a minor suggestion.

Co-authored-by: Victor Stinner <vstinner@python.org>
@sobolevn sobolevn merged commit 41a9b46 into python:main Jul 2, 2025
70 of 73 checks passed
@sobolevn
Copy link
Member Author

sobolevn commented Jul 2, 2025

We generally don't backport error message changes. If needed - please, let me know :)

@sobolevn
Copy link
Member Author

sobolevn commented Jul 2, 2025

Thanks everyone!

AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
…roxyType`s (python#136204)

Co-authored-by: Victor Stinner <vstinner@python.org>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
…roxyType`s (python#136204)

Co-authored-by: Victor Stinner <vstinner@python.org>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
…roxyType`s (python#136204)

Co-authored-by: Victor Stinner <vstinner@python.org>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
…roxyType`s (python#136204)

Co-authored-by: Victor Stinner <vstinner@python.org>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
…roxyType`s (python#136204)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants