KEMBAR78
GH-137484: Have `Tools/wasm/wasi` use the build triple instead of "build" by brettcannon · Pull Request #137485 · python/cpython · GitHub
Skip to content

GH-137484: Have Tools/wasm/wasi use the build triple instead of "build" #137485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2025
Merged

GH-137484: Have Tools/wasm/wasi use the build triple instead of "build" #137485

merged 2 commits into from
Aug 6, 2025

Conversation

@brettcannon
Copy link
Member

@brettcannon brettcannon commented Aug 6, 2025 •
edited by bedevere-app bot
Loading

This should help prevent issues where something like a container is used to do one build and then someone tries to build again locally.

@brettcannon
pythonGH-137484: Have Tools/wasm/wasi use the build triple instead …
ed8ca13 
…of "build"

This should help prevent issuse where something like a container is used to do one build and then someone tries to build again locally.
@brettcannon brettcannon added build The build process and cross-build OS-wasi needs backport to 3.14 bugs and security fixes labels Aug 6, 2025
@bedevere-app bedevere-app bot mentioned this pull request Aug 6, 2025
Closed
@brettcannon
Copy link
Member Author

!buildbot wasi

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @brettcannon for commit f71b4d0 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137485%2Fmerge

The command will test the builders whose names match following regular expression: wasi

The builders matched are:

  • wasm32-wasi Non-Debug PR
  • wasm32-wasi PR
  • wasm32 WASI 8Core PR

@brettcannon brettcannon self-assigned this Aug 6, 2025
@brettcannon brettcannon merged commit 0953200 into python:main Aug 6, 2025
44 checks passed
@brettcannon brettcannon deleted the 137484-build-triple-over-build branch August 6, 2025 19:28
@miss-islington-app
Copy link

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@brettcannon
Copy link
Member Author

It looks like miss-islington had a glitch and didn't leave a comment on the backport PR: #137487

@serhiy-storchaka
Copy link
Member

Reminder about backporting. @brettcannon

@brettcannon
Copy link
Member Author

Reminder about backporting. @brettcannon

I have a backport ready to go, but I'm waiting on 3.14 to be unfrozen for general fixes.

@bedevere-app
Copy link

bedevere-app bot commented Aug 15, 2025

GH-137487 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 15, 2025
brettcannon added a commit that referenced this pull request Oct 8, 2025
@miss-islington @brettcannon @encukou
[3.14] GH-137484: Have Tools/wasm/wasi use the build triple instead…
9e0b7d0 
… of "build" (GH-137485) (#137487)

GH-137484: Have `Tools/wasm/wasi` use the build triple instead of "build" (GH-37485)

This should help prevent issuse where something like a container is used to do one build and then someone tries to build again locally.
(cherry picked from commit 0953200)

Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brettcannon brettcannon

Labels

build The build process and cross-build OS-wasi

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brettcannon @bedevere-bot @serhiy-storchaka